[webkit-reviews] review granted: [Bug 54451] FESpecularLightingElement changes doesn't require relayout. : [Attachment 83291] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Renata Hodovan
<reni at webkit.org>'s request for review:
Bug 54451: FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451

Attachment 83291: Patch
https://bugs.webkit.org/attachment.cgi?id=83291&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83291&action=review

Looks good, r=me with some comments, to be fixed before landing:

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:261
> +

Unrelated change, please remove.

> Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp:145
> +    if (SVGFELightElement::findLightElement(this) != lightElement)

When does this happen, again? I keep forgetting.

> Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp:202
> +

Remove this empty newline.

> Source/WebCore/svg/SVGFELightElement.h:36
> +    static PassRefPtr<LightSource> findLight(const SVGElement*);

findLightSource sounds better, please rename.

> Source/WebCore/svg/SVGFESpecularLightingElement.cpp:209
> +

Empty newline, please remove.