[webkit-reviews] review requested: [Bug 23668] CSS 'content' attribute does not work with window.getComputedStyle : [Attachment 83526] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 12:42:52 PST 2011


Emil A Eklund <eae at chromium.org> has asked  for review:
Bug 23668: CSS 'content' attribute does not work with window.getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23668

Attachment 83526: Patch
https://bugs.webkit.org/attachment.cgi?id=83526&action=review

------- Additional Comments from Emil A Eklund <eae at chromium.org>
Implements getComputedStyle for the content, counter, outline-offset,
background-position-x and background-position-y properties.

To correctly return content containing counters I added a new type to
CSSPrimitiveValue, CSS_COUNTER_NAME. I'm not convinced this is the right thing
to do but was the best option I could come up with. Any suggestions would be
welcome.


More information about the webkit-reviews mailing list