[webkit-reviews] review granted: [Bug 46500] Make positioned elements work with vertical text : [Attachment 83517] Part 1: Make containing block width/height for positioned elements work with writing modes.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 46500: Make positioned elements work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46500

Attachment 83517: Part 1: Make containing block width/height for positioned
elements work with writing modes.
https://bugs.webkit.org/attachment.cgi?id=83517&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83517&action=review

> Source/WebCore/ChangeLog:5
> +	   https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned
elements work with vertical text.

Do you plan to add test cases?

> Source/WebCore/rendering/RenderBox.cpp:2077
> +	   return containingBlockLogicalWidthForPositioned(containingBlock,
false);

I hate booleans for this kind of thing! I usually ask people to use enums for
something where you always are passing a constant to it.