[webkit-reviews] review granted: [Bug 55065] Setting shadow host should also attach and set inDocument, just like appending/inserting a child. : [Attachment 83507] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 11:22:48 PST 2011


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 55065: Setting shadow host should also attach and set inDocument, just like
appending/inserting a child.
https://bugs.webkit.org/show_bug.cgi?id=55065

Attachment 83507: Patch
https://bugs.webkit.org/attachment.cgi?id=83507&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review

> Source/WebCore/dom/Element.cpp:1143
> +    if (inDocument())
> +	   newRoot->insertedIntoDocument();

Is there a case where newRoot was already in a document?


More information about the webkit-reviews mailing list