[webkit-reviews] review granted: [Bug 55024] fix svn revision number finding when creating git patches : [Attachment 83452] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 55024: fix svn revision number finding when creating git patches
https://bugs.webkit.org/show_bug.cgi?id=55024

Attachment 83452: Patch
https://bugs.webkit.org/attachment.cgi?id=83452&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83452&action=review

This or evan's version looks fine.

> Tools/Scripts/webkitpy/common/checkout/scm.py:751
> +	   match = re.search("^\s*git-svn-id:.*@(?P<svn_revision>\d+)\ .*$",
git_log, re.MULTILINE)

Nit: I'm not sure the .*$ gives you anything (aren't you always going to have
something before the end of the line?)