[webkit-reviews] review canceled: [Bug 55017] SVGImage causes MainResourceLoader leaks : [Attachment 83459] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 04:54:29 PST 2011


Xianzhu Wang <wangxianzhu at google.com> has canceled Xianzhu Wang
<wangxianzhu at google.com>'s request for review:
Bug 55017: SVGImage causes MainResourceLoader leaks
https://bugs.webkit.org/show_bug.cgi?id=55017

Attachment 83459: patch
https://bugs.webkit.org/attachment.cgi?id=83459&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at google.com>
I've tried data URL, but it didn't work:
scriptFrame.src = "data:text/html,<script src=x.js><" + "</script>"
won't load x.js at all (may be a security restriction?)
So I still use an external html for the frame.

Adopted Johnny's another suggestion, removed blank.js and use XXXXX.js in
load-script.html.
The issue can be triggered no matter the resource exists or not.

This updated patch also fixed a problem in the test case: "totalFrames = 10"
was wrong because I forgot to revert a temporary change.


More information about the webkit-reviews mailing list