[webkit-reviews] review denied: [Bug 54739] [Qt] Add a Method to QWebHistory to let the browser add items to the tab's history : [Attachment 82940] patch as descriped above

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 03:47:42 PST 2011


Benjamin Poulain <benjamin.poulain at nokia.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 54739: [Qt] Add a Method to QWebHistory to let the browser add items to the
tab's history
https://bugs.webkit.org/show_bug.cgi?id=54739

Attachment 82940: patch as descriped above
https://bugs.webkit.org/attachment.cgi?id=82940&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82940&action=review

And this needs good autotest coverage.

> WebKit/qt/Api/qwebhistory.cpp:400
> +  Adds an item to the history.

This is not good enough documentation. The doc also has to mention what are the
argument for example.

> WebKit/qt/Api/qwebhistory.cpp:402
> +void QWebHistory::addItem(QString &url, QString &title, double lastVisited)

This should be ref-to-const for url and title.
The type for lastVisited is just mirroring WebKit internal, this is not good
for Qt APIs.


More information about the webkit-reviews mailing list