[webkit-reviews] review granted: [Bug 54606] [Chromium] Control-Up/Down do not scroll by page on Chrome/Mac : [Attachment 82734] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Takashi Toyoshima
<toyoshim at google.com>'s request for review:
Bug 54606: [Chromium] Control-Up/Down do not scroll by page on Chrome/Mac
https://bugs.webkit.org/show_bug.cgi?id=54606

Attachment 82734: Patch
https://bugs.webkit.org/attachment.cgi?id=82734&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82734&action=review

r=me

I think you would want to set cq? when you ask a review for your patch.

> Source/WebKit/chromium/ChangeLog:5
> +	   Control-Up/Down should be PageUp/Down on Mac.

I think it's nice to have prefixes for this kind of platform specific changes.

> Source/WebKit/chromium/src/WebViewImpl.cpp:809
> +    // Control-Up/Down should be PageUp/Downb on Mac.

s/Downb/Down/