[webkit-reviews] review granted: [Bug 55019] Add a GYP project for JavaScriptGlue : [Attachment 83437] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 55019: Add a GYP project for JavaScriptGlue
https://bugs.webkit.org/show_bug.cgi?id=55019

Attachment 83437: Patch
https://bugs.webkit.org/attachment.cgi?id=83437&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83437&action=review

Seems useful as a first try.  Thanks.

> Source/JavaScriptGlue/gyp/JavaScriptGlue.gyp:24
> +	 'configurations': {
> +	   'Debug': {},
> +	 },

Only Debug?

> Source/JavaScriptGlue/gyp/JavaScriptGlue.gyp:28
> +	 'defines': [
> +	   'WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST',
> +	 ],

I assume you're going to rip these all out into shared gypis later? :)