[webkit-reviews] review canceled: [Bug 54935] [codereviewtool] focus first visible node if no node is focused : [Attachment 83265] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 22 19:40:16 PST 2011
Ojan Vafai <ojan at chromium.org> has canceled Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 54935: [codereviewtool] focus first visible node if no node is focused
https://bugs.webkit.org/show_bug.cgi?id=54935
Attachment 83265: Patch
https://bugs.webkit.org/attachment.cgi?id=83265&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83265&action=review
>> Websites/bugs.webkit.org/code-review.js:1412
>> + y -= 30;
>
> 30?
I picked this sort of arbitrarily. I made it a bit more explicit though and
expanded the comment a bit.
>> Websites/bugs.webkit.org/code-review.js:1415
>> + reference_element = document.elementFromPoint(100, y);
>
> 100?
This was just dumb. Using the center of the window down.
More information about the webkit-reviews
mailing list