[webkit-reviews] review denied: [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions : [Attachment 83422] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 18:34:09 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has denied  review:
Bug 54986: deprecatedEditingOffset should actually return the expected
deprecated value for "after" positions
https://bugs.webkit.org/show_bug.cgi?id=54986

Attachment 83422: Patch
https://bugs.webkit.org/attachment.cgi?id=83422&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83422&action=review

Taking back my r+ given the build failure.

> Source/WebCore/dom/Position.cpp:149
> +int Position::deprecatedOffsetForAfterPosition() const

This should be offsetForPositionAfterAnchor instead.


More information about the webkit-reviews mailing list