[webkit-reviews] review granted: [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions : [Attachment 83422] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 54986: deprecatedEditingOffset should actually return the expected
deprecated value for "after" positions
https://bugs.webkit.org/show_bug.cgi?id=54986

Attachment 83422: Patch
https://bugs.webkit.org/attachment.cgi?id=83422&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83422&action=review

The patch looks good. r=me provided you all layout tests ran successfully.

> Source/WebCore/ChangeLog:11
> +	   No tests. This is intended to simplify the transition to new
Positions, not change behavior.

not "to" change behavior?

> Source/WebCore/dom/Position.h:97
> +	   if (m_isLegacyEditingPosition || m_anchorType !=
PositionIsAfterAnchor)
> +	       return m_offset;
> +	   return offsetForPositionAfterAnchor();

Might be nice to special case position after node instead so that condition
here matches the assertion?