[webkit-reviews] review granted: [Bug 54992] Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings : [Attachment 83376] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 54992: Use AtomicString::fromUTF8 instead of String::fromUTF8 for
AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=54992

Attachment 83376: Patch
https://bugs.webkit.org/attachment.cgi?id=83376&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83376&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:2826
> +	  
priv->page_settings->setStandardFontFamily(WTF::AtomicString::fromUTF8(family))
;

Why WTF::AtomicString?

> Source/WebKit/efl/ewk/ewk_view.cpp:2842
> +	  
priv->page_settings->setCursiveFontFamily(WTF::AtomicString::fromUTF8(family));


Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:2858
> +	  
priv->page_settings->setFantasyFontFamily(WTF::AtomicString::fromUTF8(family));


Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:2874
> +	  
priv->page_settings->setFixedFontFamily(WTF::AtomicString::fromUTF8(family));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:2890
> +	  
priv->page_settings->setSerifFontFamily(WTF::AtomicString::fromUTF8(family));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:3027
> +	  
priv->page_settings->setLocalStorageDatabasePath(WTF::String::fromUTF8(path));

Ditto.