[webkit-reviews] review granted: [Bug 54889] IndexedDB: Move some SQL code into IDBBackingStore : [Attachment 83309] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 16:20:58 PST 2011


Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 54889: IndexedDB: Move some SQL code into IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=54889

Attachment 83309: Patch
https://bugs.webkit.org/attachment.cgi?id=83309&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83309&action=review

r=me

> Source/WebCore/storage/IDBBackingStore.cpp:465
> +double IDBBackingStore::autoIncrementNumber(int64_t objectStoreId)

nextAUtoIncrementNumber maybe?

> Source/WebCore/storage/IDBBackingStore.h:63
> +    void getIndexes(int64_t objectStoreId, Vector<int64_t>& foundIds,
Vector<String>& foundNames, Vector<String>& foundKeyPaths, Vector<bool>&
foundUniqueFlags);

maybe split out get/create/delete index like you did for object store?

maybe split out all the calls for puts and make it clear you need to manually
call all applicable?


More information about the webkit-reviews mailing list