[webkit-reviews] review denied: [Bug 54710] [chromium] Create a LayerChromium layerTreeAsText. Add HUD to LayerRendererChromium that draws compositor FPS and, optionally, the layer tree. : [Attachment 82907] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 12:58:13 PST 2011


James Robinson <jamesr at chromium.org> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 54710: [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally, the layer
tree.
https://bugs.webkit.org/show_bug.cgi?id=54710

Attachment 82907: Patch
https://bugs.webkit.org/attachment.cgi?id=82907&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82907&action=review

R- because this will won't submit

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

There's a presubmit check that will barf on this - you have to remove this line
and (preferably) replace it with some text describing the patch + why it
doesn't need a test.


More information about the webkit-reviews mailing list