[webkit-reviews] review granted: [Bug 54961] Web Inspector: refactor "script or resource" mess in scripts panel : [Attachment 83320] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 54961: Web Inspector: refactor "script or resource" mess in scripts panel
https://bugs.webkit.org/show_bug.cgi?id=54961

Attachment 83320: Patch.
https://bugs.webkit.org/attachment.cgi?id=83320&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83320&action=review

r+ with nits and request for tests.

> LayoutTests/inspector/debugger/scripts-panel.html:30
> +    InspectorTest.runDebuggerTestSuite([

InspectorTest.runTestSuite ?

> Source/WebCore/inspector/front-end/ScriptsPanel.js:335
> +	   // 1) Added script url is the first item in files select

Can you add tests for these? (I.e. make sure SourceFrame is not created). There
was a huge regression once in this logic.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:540
> +    _showSourceFrame: function(sourceName, addToBackForwardList,
saveAsLastViewedScriptFile)

saveAsLastViewedScriptFile -> userGesture? Aslo, I'd prefer couple of wrapper
functions with sound names instead of these two boolean params all over the
calling code.