[webkit-reviews] review granted: [Bug 54933] Make Editor::selectionComputedStyle return EditingStyle : [Attachment 83262] cleanup

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 54933: Make Editor::selectionComputedStyle return EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=54933

Attachment 83262: cleanup
https://bugs.webkit.org/attachment.cgi?id=83262&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review

> Source/WebCore/ChangeLog:9
> +	   Renamed selectionComputedStyle to selectionStartComputedStyle and
changed the return type to EditingStyle.
> +	   It also no longer takes a boolean shouldUseFixedFontDefaultSize.

I’m not sure this function needs the word computed in it any more. When the
function returned a CSS style object, then it needed computed in its name
because of how the same data structure is used for actual computed style and
other style purposes. I think maybe selectionStartStyle would be a suitable
name.