[webkit-reviews] review denied: [Bug 54971] Web Inspector: it should be possible to pass custom error text from a backend method to frontend. : [Attachment 83339] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 54971: Web Inspector: it should be possible to pass custom error text from
a backend method to frontend.
https://bugs.webkit.org/show_bug.cgi?id=54971

Attachment 83339: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=83339&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83339&action=review

> Source/WebCore/inspector/InspectorAgent.h:204
> +    void enableProfiler(InspectorArray* errors = 0);

I understand that the protocol layer allows multiple errors, but the user layer
is used to returning an error message (single string).

> Source/WebCore/inspector/InspectorAgent.h:205
> +    void disableProfiler(InspectorArray* errors = 0);

You force methods to check for errors existence - not nice.