[webkit-reviews] review requested: [Bug 32510] [GTK] provide an API to control the IconDatabase : [Attachment 83333] Implement WebKitIconDatabase API #3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 09:23:07 PST 2011


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 32510: [GTK] provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32510

Attachment 83333: Implement WebKitIconDatabase API #3
https://bugs.webkit.org/attachment.cgi?id=83333&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
Changed DumpRenderTree to use the new API.
Moved code fully into new class except for the atexit handler.
Elaborated in the introduction of the new class.
Fixed all Since tags.
Used placement new syntax, hadn't known that one before.
Allow "" to unset just like %NULL.
Used String::fromUTF8.
Synced and clarifying _get_icon_pixbuf methods.
Clarified comments on icon sizing.

Pending: use of fileSystemRepresentation, I didn't find a way to pass that
because it uses CString and I was unable to find a convertion function. Will
have to check that again.


More information about the webkit-reviews mailing list