[webkit-reviews] review granted: [Bug 54910] media/video-replaces-poster.html fails on all platforms : [Attachment 83236] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 54910: media/video-replaces-poster.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=54910

Attachment 83236: Patch
https://bugs.webkit.org/attachment.cgi?id=83236&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83236&action=review

This is a separate issue, but won't other tests that use video-paint-test.js
have this same problem?

Marking r+ but I would prefer to see the ChangeLog comment broken into multiple
lines so it is easier to read in an editor that doesn't wrap.

> LayoutTests/ChangeLog:5
> +	   Fix for media/video-replaces-poster.html.  The test was failing
because it assumes the results of a seek will be immediately available, when in
fact the seek is asynchronous.	I did not remove the line in test-expectations
because rebaselines for many (all?) platforms will likely be needed after this
patch lands.  See also,
http://code.google.com/p/chromium/issues/detail?id=60244

That is one very long line for a ChangeLog ;-)