[webkit-reviews] review granted: [Bug 54873] Can not force XML without style information to dump as text. : [Attachment 83303] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 06:00:10 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 54873: Can not force XML without style information to dump as text.
https://bugs.webkit.org/show_bug.cgi?id=54873

Attachment 83303: Patch
https://bugs.webkit.org/attachment.cgi?id=83303&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83303&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:620
> +	   setDumpPixels(false);

No layoutTestController() prefix intentional?

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:496
> +    WKBundleFrameRef frame = WKBundlePageGetMainFrame(m_page);

Why is this chance necessary?


More information about the webkit-reviews mailing list