[webkit-reviews] review granted: [Bug 54729] Web Inspector: flakyness of inspector tests : [Attachment 83301] [patch] third version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 54729: Web Inspector: flakyness of inspector tests
https://bugs.webkit.org/show_bug.cgi?id=54729

Attachment 83301: [patch] third version
https://bugs.webkit.org/attachment.cgi?id=83301&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83301&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:733
> +	   --this._pendingResponsesCount;

you should move this into dispatch (after the if/else).

> Source/WebCore/inspector/CodeGeneratorInspector.pm:815
> +	       if (this.runAfterPendingDispatches &&
!this.isWaitingForResponse())

Just move it here.

> Source/WebCore/inspector/front-end/TestController.js:77
> +    WebInspector.testController.runAfterPendingDispatches(invokeMethod);

I'd rather implement runAfterPendingDispatches on the InspectorBackendStub and
use it both: from test controller and inspectortest.