[webkit-reviews] review requested: [Bug 53916] [Qt] WebKit patches required to work with a modularized version of Qt : [Attachment 83295] Added-full-webkit-module-profile-and-a-syncqt-profile-v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 03:56:15 PST 2011


Kristian Amlie <kristian.amlie at nokia.com> has asked  for review:
Bug 53916: [Qt] WebKit patches required to work with a modularized version of
Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

Attachment 83295: Added-full-webkit-module-profile-and-a-syncqt-profile-v2
https://bugs.webkit.org/attachment.cgi?id=83295&action=review

------- Additional Comments from Kristian Amlie <kristian.amlie at nokia.com>
After discussing both with Laszlo and my own team, this is the updated patch.
The depends statement has changed to include all optional modules, and is used
by the Qt build system to order the link arguments correctly. If a module is
missing it will simply be omitted from the link as usual.

The modules mentioned inside the sync.profile stay as they are, since they
express which headers are needed, and the optional modules are not part of
that.


More information about the webkit-reviews mailing list