[webkit-reviews] review denied: [Bug 54729] Web Inspector: flakyness of inspector tests : [Attachment 83293] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 54729: Web Inspector: flakyness of inspector tests
https://bugs.webkit.org/show_bug.cgi?id=54729

Attachment 83293: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=83293&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83293&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:714
> +    this._waitForResponse = 0;

this._pendingResponseCount

> Source/WebCore/inspector/CodeGeneratorInspector.pm:732
> +	   --this._waitForResponse;

move this line to after callback.apply

> Source/WebCore/inspector/CodeGeneratorInspector.pm:815
> +	       if (this.runAfterPendingDispatches &&
WebInspector.pendingDispatches === 0 && !this.isWaitingForResponse())

pendingDispatches is of no use now.

> Source/WebCore/inspector/front-end/TestController.js:78
> +WebInspector.testController = new WebInspector.TestController();

You should not need it (leave as it was).

> Source/WebCore/inspector/front-end/TestController.js:79
> +WebInspector.evaluateForTestInFrontend =
WebInspector.testController._evaluateForTestInFrontend.bind(WebInspector.testCo
ntroller);

Leave as it was.