[webkit-reviews] review denied: [Bug 54902] [Qt] [WK2] Improve the memory handling of the context menu for WebKit 2 : [Attachment 83208] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 54902: [Qt] [WK2] Improve the memory handling of the context menu for
WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=54902

Attachment 83208: Patch
https://bugs.webkit.org/attachment.cgi?id=83208&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83208&action=review

>> Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.cpp:97
>> +	OwnPtr<QMenu> menu(new QMenu);
> 
> Why not create this as a PassOwnPtr? like in the PassRefPtr example here?
http://www.webkit.org/coding/RefPtr.html

This should use adoptPtr() or it won't build without LOOSE_PASS_OWN_PTR
defined.