[webkit-reviews] review granted: [Bug 54594] Expose isValidProtocol() in KURL.h. : [Attachment 82714] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 21 21:35:23 PST 2011
Ojan Vafai <ojan at chromium.org> has granted James Kozianski <koz at chromium.org>'s
request for review:
Bug 54594: Expose isValidProtocol() in KURL.h.
https://bugs.webkit.org/show_bug.cgi?id=54594
Attachment 82714: Patch
https://bugs.webkit.org/attachment.cgi?id=82714&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82714&action=review
> Source/WebCore/platform/KURLGoogle.cpp:136
> +bool isValidProtocol(const String& protocol)
This is missing a comment from the KURL.cpp version. May as well make the
copy-paste exact. Also, can you put a comment explaining that this is
copy-pasted from there?
More information about the webkit-reviews
mailing list