[webkit-reviews] review granted: [Bug 50945] WebKit2: Web Inspector windows don't have titles : [Attachment 83235] Proposed Change (with Qt and GTK fixed)

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 50945: WebKit2: Web Inspector windows don't have titles
https://bugs.webkit.org/show_bug.cgi?id=50945

Attachment 83235: Proposed Change (with Qt and GTK fixed)
https://bugs.webkit.org/attachment.cgi?id=83235&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83235&action=review

> Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:55
> +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString)


Could remove the urlString name here.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:54
> +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString)


And here.

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:191
> +    ::SetWindowText(m_inspectorWindow,
title.charactersWithNullTermination());

You should change this to call ::SetWindowTextW, to match other Win32 API usage
in WebKit2. (::SetWindowText is just a macro for ::SetWindowTextW, so there's
no behavioral difference.)