[webkit-reviews] review granted: [Bug 53146] [GTK] Combo boxes should emit object:selection-changed even when collapsed : [Attachment 82943] Patch proposal + Layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 21 15:54:17 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 53146: [GTK] Combo boxes should emit object:selection-changed even when
collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

Attachment 82943: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=82943&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82943&action=review

>
LayoutTests/platform/gtk/accessibility/combo-box-collapsed-selection-changed.ht
ml:12
> +  description("This tests that the 'state-changed:selected' signal is
emitted when arrowing through the options of a combobox while collapsed.");
> +
> +  if (window.layoutTestController) {

Please use 4 space indents.


More information about the webkit-reviews mailing list