[webkit-reviews] review granted: [Bug 54831] Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp : [Attachment 83135] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 21 15:14:26 PST 2011


Alexey Proskuryakov <ap at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 54831: Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp
https://bugs.webkit.org/show_bug.cgi?id=54831

Attachment 83135: Patch
https://bugs.webkit.org/attachment.cgi?id=83135&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83135&action=review

> Source/JavaScriptCore/runtime/InitializeThreading.cpp:59
> +    Structure::initializeThreading();
>  #if ENABLE(JSC_MULTIPLE_THREADS)

I think that it would be less confusing to have the call inside the #if - at
least, I was confused by seeing it in the single thread section.


More information about the webkit-reviews mailing list