[webkit-reviews] review granted: [Bug 54905] Remove global initializer in CookieStorageCFNet.cpp : [Attachment 83219] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Pratik Solanki <psolanki at apple.com>'s
request for review:
Bug 54905: Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905

Attachment 83219: Patch
https://bugs.webkit.org/attachment.cgi?id=83219&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83219&action=review

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:61
> +    if (s_cookieStorage)
> +	   CFRelease(s_cookieStorage);
> +
> +    CFRetain(cookieStorage);

The usual pattern is to put retain before release so things work properly if
s_cookieStorage and cookieStorage happen to be the same object. You could do
that here by just moving the CFRetain call up a couple lines.