[webkit-reviews] review granted: [Bug 54905] Remove global initializer in CookieStorageCFNet.cpp : [Attachment 83212] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 54905: Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905

Attachment 83212: Patch
https://bugs.webkit.org/attachment.cgi?id=83212&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83212&action=review

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:43
> -static RetainPtr<CFHTTPCookieStorageRef> s_cookieStorage;
> +static CFHTTPCookieStorageRef s_cookieStorage;

Do we need to init s_cookieStorage to 0 ?

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:70
> +	   s_cookieStorage = wkCreatePrivateHTTPCookieStorage();

Should we assert that s_cookieStorage is 0 here?