[webkit-reviews] review granted: [Bug 54585] [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase : [Attachment 82689] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 54585: [fileapi] Implement EntrySync.toURI by moving Entry::toURI to
EntryBase
https://bugs.webkit.org/show_bug.cgi?id=54585

Attachment 82689: Patch
https://bugs.webkit.org/attachment.cgi?id=82689&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82689&action=review

> Source/WebCore/fileapi/DOMFileSystem.cpp:54
> -    : DOMFileSystemBase(name, asyncFileSystem)
> +    : DOMFileSystemBase(context, name, asyncFileSystem)
>      , ActiveDOMObject(context, this)

It's too bad we end up with two pointers to the script execution context, but I
don't see a way around it.

> Source/WebCore/fileapi/EntryBase.cpp:59
> +    StringBuilder uriBuilder;

nit: I would have just called this "result" or something.

> Source/WebCore/fileapi/EntryBase.cpp:63
> +    uriBuilder.append(m_fileSystem->asyncFileSystem()->type() ==
AsyncFileSystem::Temporary ? "temporary" : "persistent");

These should use the constants, but I guess that hasn't landed yet