[webkit-reviews] review granted: [Bug 54810] Fix isLayoutTimerActive for ports that set a minimumLayoutDelay : [Attachment 83081] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 54810: Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
https://bugs.webkit.org/show_bug.cgi?id=54810

Attachment 83081: Patch
https://bugs.webkit.org/attachment.cgi?id=83081&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83081&action=review

>> Source/WebCore/ChangeLog:8
>> +	    No new tests because no new functionality.
> 
> So we have no way to test that we're yielding between tokens?  Do we have any
way to detect first paint from JS?  Certainly there is in FF, but I'm not sure
there is in WebKit.

It's very difficult to test.  It might be observable, but I can't think of how
to observe it without races.

>> Source/WebCore/dom/Document.cpp:2160
>> +	return view() && view()->layoutPending() && minimumLayoutDelay() ==
m_extraLayoutDelay;
> 
> Maybe the minimum = extra check needs itself to be a function.  Given how
strange that reads.

Yeah, if I were reading this code in the future, it would be pretty mysterious.