[webkit-reviews] review granted: [Bug 54755] REGRESSION (WebKit2): HTTP requests time out after 60 seconds : [Attachment 83201] proposed patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 54755: REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755

Attachment 83201: proposed patch
https://bugs.webkit.org/attachment.cgi?id=83201&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83201&action=review

I'm not sure I understand why we need this API on both WKURLRequest and
WKContext.

> Source/WebKit2/Shared/WebURLRequest.cpp:29
> +    WebCore::ResourceRequest::setDefaultTimeoutInterval(timeoutInterval);

No need for the WebCore::

> Source/WebKit2/Shared/WebURLRequest.cpp:32
> +
> +

Extra blank line here.

> Source/WebKit2/WebProcess/WebProcess.cpp:233
> +    ResourceRequestBase::setDefaultTimeoutInterval(timeoutInterval);

Why "ResourceRequestBase" instead of "ResourceRequest", like WebURLRequest.cpp
uses?