[webkit-reviews] review denied: [Bug 54898] InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle : [Attachment 83200] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 21 12:05:36 PST 2011


Adam Roben (aroben) <aroben at apple.com> has denied Alice Liu
<alice.liu at apple.com>'s request for review:
Bug 54898: InjectedBundleNodeHandle dies too early in
WKBundleHitTestResultGetNodeHandle
https://bugs.webkit.org/show_bug.cgi?id=54898

Attachment 83200: patch
https://bugs.webkit.org/attachment.cgi?id=83200&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
My guess is that you're fixing a crash. It would be good to have "crash"
somewhere in the bug title (which would also get it into your ChangeLog).

As you suspected, this change makes WKBundleHitTestResultGetNodeHandle follow
the Create or Copy pattern, so its name will have to be changed.

The actual code change seems fine. Is it possible to make a test for this? I'd
imagine it is, by using TestWebKitAPI.


More information about the webkit-reviews mailing list