[webkit-reviews] review requested: [Bug 53591] print-vse-failure-logs: "Found 0 VSE Build Logs" and "WebKit/WebKitBuild/obj" is not there : [Attachment 83192] Patched print-vse-failure-logs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 21 11:07:29 PST 2011
Felipe <f.dachshund at gmail.com> has asked for review:
Bug 53591: print-vse-failure-logs: "Found 0 VSE Build Logs" and
"WebKit/WebKitBuild/obj" is not there
https://bugs.webkit.org/show_bug.cgi?id=53591
Attachment 83192: Patched print-vse-failure-logs
https://bugs.webkit.org/attachment.cgi?id=83192&action=review
------- Additional Comments from Felipe <f.dachshund at gmail.com>
Patch for print-vse-failure-logs accept now options "--debug" or "--release".
Lines 114-128 read this possible option, printing help if an error occurs.
Class PrintVisualStudioExpressLogs now take one argument "mode", wich can be
"--debug" or "--release" or "" (default is "") and is stored as a new attribute
self._mode , so the constructor of the class was changed (lines 47, 49) as
well as the call to the class in line 129. Options "--configuration" (instead
of "--top-level") and self._mode are passed to the script
webkit-build-directory in line 86. A "# NOTE:" in method "_obj_directory" was
removed, since it's obsolete.
New copyright line was added.
More information about the webkit-reviews
mailing list