[webkit-reviews] review granted: [Bug 54891] Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent : [Attachment 83189] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 54891: Web Inspector: make DOM storage and Database agents have the same
lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54891

Attachment 83189: Patch
https://bugs.webkit.org/attachment.cgi?id=83189&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83189&action=review

> Source/WebCore/inspector/InspectorAgent.cpp:65
>  #include "InspectorDatabaseResource.h"

nuke this too?

> Source/WebCore/inspector/InspectorAgent.cpp:343
> +#if ENABLE(DOM_STORAGE)

Move them below the base agents?

> Source/WebCore/inspector/InspectorAgent.cpp:346
> +#if ENABLE(DATABASE)

This goes first.