[webkit-reviews] review granted: [Bug 54879] Web Inspector: navigation does not work after reopening frontend : [Attachment 83177] [PATCH] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 21 10:16:22 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 54879: Web Inspector: navigation does not work after reopening frontend
https://bugs.webkit.org/show_bug.cgi?id=54879

Attachment 83177: [PATCH] Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=83177&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83177&action=review

> LayoutTests/http/tests/inspector-enabled/open-close-open.html:24
> +	   layoutTestController.showWebInspector();

How can we be sure that the front-end has already closed? What if there are
some unfinished tasks in the front-end?

> LayoutTests/http/tests/inspector-enabled/open-close-open.html:52
> +Tests that Web Inspector is functional after the open - close - open
sequence.

Please include link to the bug in the test description.

> Source/WebCore/inspector/InspectorState.h:53
> +    void unmute();

Consider replacing these two methods with a setter.


More information about the webkit-reviews mailing list