[webkit-reviews] review denied: [Bug 54876] Web Inspector: [Text editor] Bug in the highlighter : [Attachment 83155] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at google.com>'s request for review:
Bug 54876: Web Inspector: [Text editor] Bug in the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54876

Attachment 83155: Patch
https://bugs.webkit.org/attachment.cgi?id=83155&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83155&action=review

> LayoutTests/inspector/editor/highlighter-bugs-test-expected.txt:3
> +doTestForBug1()

Bug1?

> LayoutTests/inspector/editor/highlighter-bugs-test-expected.txt:7
> +    0 : {

Could you use a more dense format? (Look at syntax-highlight-* tests for
inspiration).

> LayoutTests/inspector/editor/highlighter-bugs-test.html:14
> +    window.setTimeout = function(func) {

Bad things may happen. You should either use sniffers
(InspectorTest.addSniffer) or extend highlighter API (add "immediately"
optional parameter) to workaround asynchronous operations.