[webkit-reviews] review granted: [Bug 54822] Web Inspector: generate protocol documentation based on IDL. : [Attachment 83092] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 21 02:57:14 PST 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 54822: Web Inspector: generate protocol documentation based on IDL.
https://bugs.webkit.org/show_bug.cgi?id=54822
Attachment 83092: Patch
https://bugs.webkit.org/attachment.cgi?id=83092&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83092&action=review
>> Source/WebCore/inspector/CodeGeneratorInspector.pm:394
>> +}
>
> Please use inline text. It is significantly increasing readability.
I second this comment.
> Source/WebCore/inspector/CodeGeneratorInspector.pm:521
> + push(@lines, " command: \"${functionName}\"");
This line can be pulled out of the if block.
More information about the webkit-reviews
mailing list