[webkit-reviews] review denied: [Bug 54858] Web Inspector: elementsPanel are flaky, at startup it selects <html> or <body> element depends on timing : [Attachment 83137] [patch] initial version

Mon Feb 21 02:29:26 PST 2011

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 54858: Web Inspector: elementsPanel are flaky, at startup it selects <html>
or <body> element depends on timing
https://bugs.webkit.org/show_bug.cgi?id=54858

Attachment 83137: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=83137&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83137&action=review

> Source/WebCore/ChangeLog:5
> +	   Web Inspector: elementsPanel are flaky, at startup it selects <html>
or <body> element depends on timing

Elements panel is ... depending on the timing.

> Source/WebCore/inspector/front-end/ElementsPanel.js:162
> +	   if (this.focusedDOMNode &&
!this._focusedNodeWasAutomaticallySelected)

We should only restore selection upon domContentLoaded event instead.