[webkit-reviews] review granted: [Bug 54724] Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect start/end of selection for RTL : [Attachment 83115] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin (Ben) Kalman
<kalman at chromium.org>'s request for review:
Bug 54724: Extending selection by a boundary granularity
(LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect start/end of
selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724

Attachment 83115: Patch
https://bugs.webkit.org/attachment.cgi?id=83115&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83115&action=review

> Source/WebCore/ChangeLog:11
> +	   This is achieved by extending from the start of selection when going
left, or extending from the end when going
> +	   right (as opposed from always extending from the extent).

I don't think this comment is a bit misleading since selection is always
extended logically and we never "go left" or "go right" when extending the
selection.  I think what you mean is that when the selection is extended by the
left arrow key and the right arrow key.  Please revise this before landing the
patch.