[webkit-reviews] review denied: [Bug 54853] Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow : [Attachment 83133] patch - including moved files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 21 00:08:24 PST 2011


Kent Tamura <tkent at chromium.org> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 54853: Move TextControlInnerElements from WebCore/rendering to
WebCore/html/shadow
https://bugs.webkit.org/show_bug.cgi?id=54853

Attachment 83133: patch - including moved files
https://bugs.webkit.org/attachment.cgi?id=83133&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83133&action=review

The patch will lose svn revision history.
Please make a patch in svn checkout.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22479
> +				14C0BC651312432C0030E8AB /*
TextControlInnerElements.h in Headers */,

The file list should be sorted.
It's ok to run sort-Xcode-project-file after you commit this patch.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25168
> +				14C0BC641312432C0030E8AB /*
TextControlInnerElements.cpp in Sources */,

ditto.


More information about the webkit-reviews mailing list