[webkit-reviews] review denied: [Bug 54832] Use WTF::Mutex in JSLock : [Attachment 83101] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 20 17:27:01 PST 2011


Alexey Proskuryakov <ap at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 54832: Use WTF::Mutex in JSLock
https://bugs.webkit.org/show_bug.cgi?id=54832

Attachment 83101: Patch
https://bugs.webkit.org/attachment.cgi?id=83101&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
There is a race condition initializing the static mutex now. Typically, we
would create the static mutex from JSC::initializeThreading().

But I don't think that you need JSLock to work at all. The only times it's used
with LockForReal argument is for deprecated Mac OS X SPI behavior where
concurrent access to a JS context was serialized with a mutex automagically.


More information about the webkit-reviews mailing list