[webkit-reviews] review granted: [Bug 54700] fix various bugs causing test-webkitpy to fail on win32 : [Attachment 83047] update w/ review feedback, more testing

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54700: fix various bugs causing test-webkitpy to fail on win32
https://bugs.webkit.org/show_bug.cgi?id=54700

Attachment 83047: update w/ review feedback, more testing
https://bugs.webkit.org/attachment.cgi?id=83047&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83047&action=review

> Tools/Scripts/webkitpy/common/net/testoutput_unittest.py:67
> +	   filename = filename.replace('/', os.path.sep)
> +	   expected_test_name = expected_test_name.replace('/', os.path.sep)

Maybe to be more clear we should only be doing this on non-cygwin windows?
That's the only case where this does something, right?

> Tools/Scripts/webkitpy/common/net/testoutput_unittest.py:74
> +	   filename = filename.replace('/', os.path.sep)

ditto