[webkit-reviews] review requested: [Bug 54808] Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc : [Attachment 83077] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 19 09:24:11 PST 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 54808: Change jsc target to build directly into
JavaScriptCore.framework/Resources/jsc
https://bugs.webkit.org/show_bug.cgi?id=54808
Attachment 83077: Patch
https://bugs.webkit.org/attachment.cgi?id=83077&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
* Configurations/Base.xcconfig: Added
JAVASCRIPTCORE_FRAMEWORKS_DIR variable.
* Configurations/JavaScriptCore.xcconfig: Used
JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH.
* JavaScriptCore.xcodeproj/project.pbxproj: Set the INSTALL_PATH
for Production configuration of jsc target.
(Copy Into Framework): Removed old build phase.
(Fix Framework Reference): Renamed build phase to "Copy Into
Framework". Added "set -x" call to make the script print the
commands it is running. Added code to exit early for Production
builds since this was never intended for them. Added code to
copy jsc into the JavaScriptCore.framework/Resources directory.
---
4 files changed, 31 insertions(+), 21 deletions(-)
More information about the webkit-reviews
mailing list