[webkit-reviews] review granted: [Bug 54771] WebKit2: Media document videos play only sound, no video (affects trailers.apple.com) : [Attachment 83007] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 18 19:29:00 PST 2011
Sam Weinig <sam at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 54771: WebKit2: Media document videos play only sound, no video (affects
trailers.apple.com)
https://bugs.webkit.org/show_bug.cgi?id=54771
Attachment 83007: Patch
https://bugs.webkit.org/attachment.cgi?id=83007&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review
> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533
> // Also don't claim to support accelerated rendering when in the media
document, as we will then render
> // via QTMovieView which is already accelerated.
> - return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil &&
!m_player->inMediaDocument();
> + return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil;
The comment here seems incorrect now.
More information about the webkit-reviews
mailing list