[webkit-reviews] review granted: [Bug 54517] Ensure loading has stopped in HistoryController::goToItem : [Attachment 82993] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Charles Reis
<creis at chromium.org>'s request for review:
Bug 54517: Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Attachment 82993: Patch
https://bugs.webkit.org/attachment.cgi?id=82993&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82993&action=review

> Source/WebCore/page/Page.cpp:-347
> -	       databasePolicy = DatabasePolicyContinue;

I think with this change we no longer need DatabasePolicyContinue (or the whole
enum), since we always stop databases when stopping loads. Perhaps add a FIXME
to FrameLoader::stopAllLoaders to remove that option?

>
LayoutTests/http/tests/navigation/resources/forward-to-fragment-fires-onload-2.
html:31
> +    setTimeout(function() {

If it's important that this happen after after the page finishes parsing (any
ideas why?), doing it in a DOMContentLoaded event listener seems more reliable
than a setTimeout 0.