[webkit-reviews] review denied: [Bug 52280] [GStreamer] support in mac video fullscreen controller : [Attachment 78664] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 52280: [GStreamer] support in mac video fullscreen controller
https://bugs.webkit.org/show_bug.cgi?id=52280

Attachment 78664: proposed patch
https://bugs.webkit.org/attachment.cgi?id=78664&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78664&action=review

Seems we could use functions to abstract away some of this, no?

> WebKit/mac/WebView/WebVideoFullscreenController.mm:117
> +    [window setHasShadow:YES]; // This is nicer with a shadow.
> +    [window setLevel:NSPopUpMenuWindowLevel-1];

Seems this is shared with the QT path, no?