[webkit-reviews] review granted: [Bug 54687] Invalid label can be added into backtrack when building with armcc : [Attachment 82858] the fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 11:56:03 PST 2011


Eric Seidel <eric at webkit.org> has granted Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 54687: Invalid label can be added into backtrack when building with armcc
https://bugs.webkit.org/show_bug.cgi?id=54687

Attachment 82858: the fix
https://bugs.webkit.org/attachment.cgi?id=82858&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We've had related trouble with bitfields using MSVC as well.  There the problem
was that enum is a "signed int" and when you make it a bitfield it uses one of
the bits as a sign when you don't expect it to. :)

This change seems fine.  Seems you might want a comment here to explain why you
need the "signed" part.


More information about the webkit-reviews mailing list